search

inProgress-team / react-native-meteor

Meteor Reactivity for your React Native application :)
MIT License
693 stars 210 forks source link

Fixed deprecated React.createClass() to a new module createReactClass() #270

Closed rj-david closed 7 years ago

rj-david commented 7 years ago

React has deprecated React.createClass() function but they separated it to a new module create-react-class for those using mixins. Just changed the function call from the deprecated function to the new module

xerotolerant commented 7 years ago

I think this needs to be merged now, createContainer outright fails with react native 0.48.4.

jon617 commented 7 years ago

Please commit this so my react-native-meteor will work!

I'm getting an error: "createClass is not a function" when using react-native-meteor with the 1.1.0 (latest) release of react-native-meteor. The problem should be fixed from the commit referenced above, which changes React.createClass() to newly created createReactClass().

tquiroga commented 7 years ago

I just took a course on React Native and can't practice as this PR needs to be merged. Not cool

xerotolerant commented 7 years ago

Guys the inProgress team is probably busy or moved on to another framework. Just make a branch of your own and do the merge.

https://stackoverflow.com/questions/10386310/how-to-install-a-private-npm-module-without-my-own-registry

You can follow this to do it. The beauty of open source is that you don't have to wait for anybody to do anything.

On Fri, 13 Oct 2017 at 11:30 AM Thomas Quiroga notifications@github.com wrote:

I just took a course on React Native and can't practice as this PR needs to be merged. Not cool

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/inProgress-team/react-native-meteor/pull/270#issuecomment-336486504, or mute the thread https://github.com/notifications/unsubscribe-auth/AQaDGHb6MnPOExZyK_x-Xc3piMMexv7xks5sr4IsgaJpZM4POcyd .

jon617 commented 7 years ago

I applied the fix in my fork, you're welcome to use mine, although I recommended you fork the fix yourself and use your own.

In package.json, under the dependencies section: "react-native-meteor": "https://github.com/jon617/react-native-meteor/tarball/master",

charpeni commented 7 years ago

Sorry for the delay.

We'll shortly release a version for the latest version of React Native & React.

rj-david commented 7 years ago

@charpeni, createContainer was deprecated by the meteor team last week. Just, FYI.