inProgress-team / react-native-meteor

Meteor Reactivity for your React Native application :)
MIT License
693 stars 210 forks source link

update NetInfo dependency #343

Open pkcwong opened 5 years ago

pkcwong commented 5 years ago

Fix for https://github.com/inProgress-team/react-native-meteor/issues/342

Changed NetInfo dependency from react-native to @react-native-community as suggested in React Native docs.

https://facebook.github.io/react-native/docs/netinfo.html

ghost commented 5 years ago

Please merge this PR. Facing NetInfo issue on RN 0.60

pkcwong commented 5 years ago

Same issue goes for AsyncStorage as well, I think a few other packages too

jakeols commented 5 years ago

Anything else that can be done for this? Getting the error undefined is not an object (evaluating '_reactNative.NetInfo.isConnected') relating to this.

pkcwong commented 5 years ago

My workaround now is to clone this entire repo, then add the directory as an Npm dependency. Here is an example. https://github.com/pkcwong/react-native-meteor-starter/tree/master/libs/react-native-meteor Note I cloned this repo into a /libs directory in my project. Then in my package.json I do this.

"react-native-meteor": "file:./libs/react-native-meteor"

https://github.com/pkcwong/react-native-meteor-starter/blob/master/package.json#L13

You can then fix the dependencies yourself.

ma-lemire commented 5 years ago

Plz merge this fix !

pkcwong commented 5 years ago

@ma-lemire Last commit to this repo is nearly a year ago. You can use this workaround for now. https://github.com/inProgress-team/react-native-meteor/pull/343#issuecomment-512529064

ma-lemire commented 5 years ago

@pkcwong Thx man works well ! i just add async-storage with @react-native-community/async-storage

JonahGroendal commented 4 years ago

@charpeni could you merge this pls?

JonahGroendal commented 4 years ago

downgrading react-native to 0.59.10 works as an alternative to https://github.com/inProgress-team/react-native-meteor/pull/343#issuecomment-512529064

wallind commented 4 years ago

My team ran into this issue and was able to fix it using the commit in this PR. This is a definitive issue with using React Native versions 0.60.0 and above.

@charpeni please merge this PR into the repo