inab / benchmarking-data-model

OpenEBench Benchmarking Data Model repository
Creative Commons Attribution Share Alike 4.0 International
2 stars 7 forks source link

Reserve " t " for temporary identifiers #82

Closed vsundesha closed 5 years ago

vsundesha commented 5 years ago

As we discussed earlier we will be using the letter " t " after the community id to specify the temporary_id before it is uploaded to the database. ex: _OEBX001txxxxxxxxxxxxxxxxxxxxxx The new regex pattern would be something like:

*^OEBX[0-9]{3}(t.|[A-Z0-9]{7})$**

This would validate both the ids

jlgelpi commented 5 years ago

Any length? or OEB?[0-9]{3}[tA-Z0-9][A-Z0-9]{6}

vsundesha commented 5 years ago

Could be anything a url or a string or just one digit after the "t" it wouldn't matter.

redmitry commented 5 years ago

{7} siete!  (seven, семь, saat, set) digitos!!! :D

On 2/18/2019 3:50 PM, vsundesha wrote:

As we discussed earlier we will be using the letter " t " after the community id to specify the temporary_id before it is uploaded to the database. ex: /OEBX001t000001/ The new regex pattern would be something like:

^OEBX[0-9]{3}(t.|[A-Z0-9]{7})$*

This would validate both the ids

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/inab/benchmarking-data-model/issues/82, or mute the thread https://github.com/notifications/unsubscribe-auth/AGfViPdCC8MaDSN8hl5m1tEO9cppCi0qks5vOr2ngaJpZM4bBBuN.

jmfernandez commented 5 years ago

Gentlemen, I have just fixed this issue with commit aa7444bf81b52290683fb8cfa72be92f10e116ac , with the updated patterns. Temporal ids must have the first alphanumeric symbol after the community id set to 't', and the other six alphanumeric symbols are as always

vsundesha commented 5 years ago

@jmfernandez @jlgelpi Don't we need the temporary id to be anything after the "t" because the pattern we have implemented restricts the user to have an id of 6 six alphanumeric symbols, if the ids came from a community we would only have to add the prefix OEBX001t+ the id defined by the community.

jlgelpi commented 5 years ago

The pattern I see is just accepting a "t" in the first digit and keeps the original length.

jmfernandez commented 5 years ago

@vsundesha , as @jlgelpi is telling, the identifier length is kept in this way

vsundesha commented 5 years ago

@jmfernandez I understand that, we can discuss this F2F but i don't see why we have to restrict the temporary id to be somthing like OEBX001t000000 when it can be OEBX001t*****

jlgelpi commented 5 years ago

Temporary ids can be anything, anb probably we do not need 7 digits, it was just to keep a similar pattern. In any case some pattern should be applied, otherwise the data management at the backend is more complicated

jlgelpi commented 5 years ago

Dmitry: A simple and controlled way to get temporary ids, i.e OEB001t+hash of fixed length made from the orig_id This would allow to recover the temporary id in any case from the original in case that is reused in additional uploads