search

inab / benchmarking-data-model

OpenEBench Benchmarking Data Model repository
Creative Commons Attribution Share Alike 4.0 International
2 stars 7 forks source link

Dataset, Datalink types #88

Closed jlgelpi closed 3 years ago

jlgelpi commented 5 years ago

-Not sure which is the meaning of datalink types: "compressed", "archive", "metalink", "sums"

-Curie may need to indicate a resolver system

jmfernandez commented 5 years ago

The attrs array tries to describe the meaning of the URI through the enum, but some cases should not happen. I have just pushed a new version (commit df380476fe22e063f327b7e7485cd8e87b238fe9), redoing the uri with a oneOfconstruction, so other keys are not valid in the case of embedded JSON data. Also, the documentation has improved a bit.

I'm leaving this issue open, so @javi-gv94 and @jlgelpi can check with their implementations and data the changes' correctness. We can even change the name of the uri key to data in the case of embedded JSON data

javi-gv94 commented 5 years ago

I have already tested the new uri feature and works for me. I attach a zip with three examples of how I am currently building the different datasets datasets.zip

Let me know if that's how we want the datalink

jmfernandez commented 5 years ago

Seems good. Looking at them, it is more clear we need a change for the embedded data case, so we do not include unneeded nested structures

jmfernandez commented 5 years ago

Now you have used changes from dfa3cad126f5b8d0f0d2ecc1e2b55d399dc9cd72 and 1aabbef3190acb46341a2af87c114f773e357575 , should we close this issue?