inadarei / pubsubhubbub

Automatically exported from code.google.com/p/pubsubhubbub
Other
0 stars 0 forks source link

Protocol: Conflict between spec and demo hub as to what is a valid subscriber's callback response. #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
SUMMARY:

Conflict between spec and demo hub as to what is a valid subscriber's
callback response.

RELEVANT SECTION:  7.3 Content distribution

COMMENT/REQUEST:

"The response from the subscriber's callback URL MUST be an HTTP success
(2xx) code."

The test hub only recognizes 200 and 204 has success. I was tempted to use
the 201 status code and return the created URIs for debugging/testing
purposes and got bitten by this.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html

Original issue reported on code.google.com by kugutsu...@gmail.com on 2 Oct 2009 at 2:39

GoogleCodeExporter commented 9 years ago
Yes this is a bug in the Hub implementation! Thanks for the report.

Original comment by bslatkin on 2 Oct 2009 at 8:41

GoogleCodeExporter commented 9 years ago
I came across this bug as well - since the spec says that it want a confirmation
right away I thought that a 202 Accepted would be suitable to tell the hub that 
I had
received the XML but not processed it - only queued it.

Original comment by VoxPe...@gmail.com on 2 Jan 2010 at 6:05

GoogleCodeExporter commented 9 years ago
It hasn't been patched yet. Until then I suggest you return 200 or 204.

Original comment by kugutsu...@gmail.com on 3 Jan 2010 at 3:05

GoogleCodeExporter commented 9 years ago

Original comment by bslatkin on 26 Feb 2010 at 11:03

GoogleCodeExporter commented 9 years ago
I would argue that 200 should be defined as a failure, anyway.  I believe it's 
been
brought up on the list previously, but if a hub moves/shuts down/etc., then it's
possible that any page in its place would simply return 200 because that's what 
pages
do.  The hub will continue to POST to a subscriber until the subscription 
expires or
auto-refresh kicks in and determines that the lease is no longer valid.  (Which 
could
be months or years from now, depending on the hub implementation.)

Successful codes for a POST of this sort should be > 200.  201 or 202 
specifically,
but others would be acceptable.

Original comment by jrossi...@gmail.com on 10 Mar 2010 at 11:16

GoogleCodeExporter commented 9 years ago
Fixed in r363

Original comment by bslatkin on 3 Jun 2010 at 11:53