search

inaes-tic / mbc-etiquette

Dynamic filters for melt or melted using webvfx and node express server
GNU Affero General Public License v3.0
4 stars 5 forks source link

make canvas size a setting #4

Open hatsch opened 11 years ago

hatsch commented 11 years ago

do you think it's possible to make the resolution of the drawing canvas an configurable option ( preferable in a config file)? i am asking this because while we are using PAL for playout it's Anamorphic widescreen, so the equivalent to the 720x576video , would be a filter size of 1024x576

jmrunge commented 11 years ago

Its one of our requirements! Thanks for pointing it out!

2013/10/11 hatsch notifications@github.com

do you think it's possible to make the resolution of the drawing canvas an configurable option ( preferable in a config file)? i am asking this because while we are using PAL for playout it's Anamorphic widescreen, so the equivalent to the 720x576video , would be a filter size of 1024x576

— Reply to this email directly or view it on GitHubhttps://github.com/inaes-tic/webvfx-dynamic-filters/issues/4 .

xaiki commented 11 years ago

I think @xleo had it working already

Niv Sardi, mobile. On Oct 11, 2013 8:48 AM, "Juan Martin Runge" notifications@github.com wrote:

Its one of our requirements! Thanks for pointing it out!

2013/10/11 hatsch notifications@github.com

do you think it's possible to make the resolution of the drawing canvas an configurable option ( preferable in a config file)? i am asking this because while we are using PAL for playout it's Anamorphic widescreen, so the equivalent to the 720x576video , would be a filter size of 1024x576

— Reply to this email directly or view it on GitHub< https://github.com/inaes-tic/webvfx-dynamic-filters/issues/4> .

— Reply to this email directly or view it on GitHubhttps://github.com/inaes-tic/webvfx-dynamic-filters/issues/4#issuecomment-26131258 .

jmrunge commented 11 years ago

2013/10/11 Niv Sardi notifications@github.com

I think @xleo had it working already

@lvidarte should push it then, its not on his branch. And it would be nice to have a PR on this so we can merge it to master.

Niv Sardi, mobile. On Oct 11, 2013 8:48 AM, "Juan Martin Runge" notifications@github.com wrote:

Its one of our requirements! Thanks for pointing it out!

2013/10/11 hatsch notifications@github.com

do you think it's possible to make the resolution of the drawing canvas an configurable option ( preferable in a config file)? i am asking this because while we are using PAL for playout it's Anamorphic widescreen, so the equivalent to the 720x576video , would be a filter size of 1024x576

— Reply to this email directly or view it on GitHub< https://github.com/inaes-tic/webvfx-dynamic-filters/issues/4> .

— Reply to this email directly or view it on GitHub< https://github.com/inaes-tic/webvfx-dynamic-filters/issues/4#issuecomment-26131258>

.

— Reply to this email directly or view it on GitHubhttps://github.com/inaes-tic/webvfx-dynamic-filters/issues/4#issuecomment-26131892 .

josx commented 11 years ago

Just you to know, I am working on a complete refactor of this code to match caspa standars.

You can send params to the url to change used resolution Like this ?width=1024&height=576&scale=1

hatsch commented 11 years ago

@josx thanks for the tip! sending url params works perfectly! so this issue can be closed?

xaiki commented 11 years ago

Maybe it should be: make canvas change more obvious.

Keep it open, we'll close it after refactor by @josx

Niv Sardi, mobile. On Oct 11, 2013 10:06 AM, "hatsch" notifications@github.com wrote:

@josx https://github.com/josx thanks for the tip! sending url params works perfectly! so this issue can be closed?

— Reply to this email directly or view it on GitHubhttps://github.com/inaes-tic/webvfx-dynamic-filters/issues/4#issuecomment-26135354 .

jmrunge commented 11 years ago

2013/10/11 José Luis Di Biase notifications@github.com

Just you to know, I am working on a complete refactor of this code to match caspa standars.

@jmrunge https://github.com/jmrunge you can send params to the url to change used resolution like this ?width=1024&height=576&scale=1

I know that, but what would be great is to have this params in a config file and not having to manually set them on the URL.

— Reply to this email directly or view it on GitHubhttps://github.com/inaes-tic/webvfx-dynamic-filters/issues/4#issuecomment-26134533 .

xaiki commented 11 years ago

Didn't we spend more time talking about this than making the actual patch ?

Niv Sardi, mobile. On Oct 11, 2013 10:12 AM, "Juan Martin Runge" notifications@github.com wrote:

2013/10/11 José Luis Di Biase notifications@github.com

Just you to know, I am working on a complete refactor of this code to match caspa standars.

@jmrunge https://github.com/jmrunge you can send params to the url to change used resolution like this ?width=1024&height=576&scale=1

I know that, but what would be great is to have this params in a config file and not having to manually set them on the URL.

— Reply to this email directly or view it on GitHub< https://github.com/inaes-tic/webvfx-dynamic-filters/issues/4#issuecomment-26134533>

.

— Reply to this email directly or view it on GitHubhttps://github.com/inaes-tic/webvfx-dynamic-filters/issues/4#issuecomment-26135669 .

hatsch commented 11 years ago

i just noticed that while the canvas on the editor page is resized according to the url parameters the html shown in the filter is still the old (hard-coded?) size. so the items are too far on the right side, and seem a little bit stretched

also the safe area seems unchanged..