search

inaka / cowboy_swagger

Swagger integration for Cowboy (built on trails)
http://inaka.net/blog/2015/08/19/cowboy-swagger/
Apache License 2.0
121 stars 58 forks source link

Fix a few static analysis warnings #116

Closed paulo-ferraz-oliveira closed 5 years ago

paulo-ferraz-oliveira commented 5 years ago

This version will fail on OTP 20, though, due to the use of an old cowlib version.

Warning is call to crypto:rand_bytes/1 will fail, since it was removed in 20.0; use crypto:strong_rand_bytes/1

paulo-ferraz-oliveira commented 5 years ago

At the same time, if this could be published as 1.2.4, that would be 👍

paulo-ferraz-oliveira commented 5 years ago

@elbrujohalcon: I updated the PR as per your comments and bumped OTP 19.2 to 19.3, in the Travis bit.

elbrujohalcon commented 5 years ago

@paulo-ferraz-oliveira You = ?THE_MAN! 🤘

paulo-ferraz-oliveira commented 5 years ago

@paulo-ferraz-oliveira You = ?THE_MAN! 🤘

😄 once Travis is finished, if you're OK with the PR could you merge it and tag it (also publish to hex?). Thanks.