search

inaka / elvis

Erlang Style Reviewer
Apache License 2.0
426 stars 87 forks source link

New Rule: avoid high number of export_types #539

Closed paulo-ferraz-oliveira closed 4 years ago

paulo-ferraz-oliveira commented 4 years ago

e.g. like god_module, but for -export_type.

Ideas?

elbrujohalcon commented 4 years ago

Is that even an issue anywhere?

I mean… people not defining enough types… I've seen a lot. People defining too many types… I have yet to meet the first one of them.

paulo-ferraz-oliveira commented 4 years ago

I didn't come up with this; I saw it in production code. 😄 If it's not an issue, sure, it's not an issue.

elbrujohalcon commented 4 years ago

And now I want to see that code!!!

paulo-ferraz-oliveira commented 4 years ago

Oh, it's not shared online 😞. But I can tell you this: it's not a god module, but it has more than 20 types 😄. When I suggested the idea, it would be for a number like that: at least 20 types. No worries, though; we'll get there. There's so much more interesting stuff to implement and fix, like that ignore that's been itching.