search

inaka / elvis

Erlang Style Reviewer
Apache License 2.0
426 stars 87 forks source link

Move from Travis CI to GitHub Actions? #555

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

Would you be interested in a pull request that moves CI from Travis CI to GitHub Actions, or at least adds GitHub Actions alongside Travis CI? It seems travis-ci.org will stop being useful from Dec 31 2020. I can do it, except that I think you need to create the workflow yml, first, in master, after which I can branch off of.

We should probably do the same for elvis_core if this proposal is accepted.

jfacorro commented 3 years ago

I didn't know about Travis CI being no longer useful. 😱

I would welcome a PR for using Github actions. I don't think it is required to add it to master first, my experience is that the changes done in a branch will trigger the actions if they are enabled in the repo. I will double check this though.

paulo-ferraz-oliveira commented 3 years ago

You don't need to add it to master, but it'll only get triggered/available after merge to master, right?

if they are enabled in the repo

Which they aren't, in elvis' case, are they?

Edit: anyway, I'm pull request'ing. 😄

jfacorro commented 3 years ago

I didn't know about Travis CI being no longer useful. 😱

I misunderstood, I have now looked it up and noticed you mentioned travis-ci.org that is shutting down, but it will still be possible to use travis-ci.com for open source projects though.

You don't need to add it to master, but it'll only get triggered/available after merge to master, right?

AFAIU they will get triggered in the branch where the workflow is created.

Which they aren't, in elvis' case, are they?

I can enable those. I just checked and they were already enabled. 😄

paulo-ferraz-oliveira commented 3 years ago

https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing: "which allows around 1000 minutes in a Linux environment."

https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions: "GitHub Actions usage is free for public repositories and self-hosted runners." (at least, until... 😄)

paulo-ferraz-oliveira commented 3 years ago

You can probably check consumption here: https://github.com/organizations/inaka/settings/billing.

paulo-ferraz-oliveira commented 3 years ago

This was closed the moment #558 was too.