search

inaka / elvis

Erlang Style Reviewer
Apache License 2.0
426 stars 87 forks source link

Fix broken yml for GitHub Actions #559

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

It seems to now be failing due to a failing rebar3 version (the one packed with the Docker container). These have since been updated.

paulo-ferraz-oliveira commented 3 years ago

Converting to draft to check if Action setup-erlang would solve the (apparently caused by) rebar3 issues. This is not required.

paulo-ferraz-oliveira commented 3 years ago

I'm trying to make CI's rebar3 not change between different containers. While this isn't done, I'm going to use setup-erlang for a quick fix. It's done!

paulo-ferraz-oliveira commented 3 years ago

List of Erlang versions (our CI) is currently: 19.2, 20.3, 21.3, 22.0. List of setup-erlang supported version is currently: http://packages.erlang-solutions.com/erlang/debian/pool/.

I'll need to fix the mismatch. I abandoned this since it's harder to maintain.

paulo-ferraz-oliveira commented 3 years ago

Still not Okay :( it seems setup-erlang prefixes the version with https://packages.erlang-solutions.com/erlang/debian/pool/esl-erlang_erlang: and suffixes it with -1~ubuntu~bionic_amd64.deb, so I need to work with that.

Edit: actually, no, the erlang: bit is a stupid typo on my behalf.

paulo-ferraz-oliveira commented 3 years ago

I'll look at this later. I guess the way it's build now it's not creating a proper .git locally; some adjustments might be required.

paulo-ferraz-oliveira commented 3 years ago

Installing Git 2.18 takes a while (2.5 minutes) but otherwise the Git SUITE won't run properly, since I can't make the checkout action create a repo. with a previous Git version. We can, otherwise, not run certain parts of the test code for older OTP versions, but I'm thinking that's probably not a better solution.

paulo-ferraz-oliveira commented 3 years ago

It seems we might be missing a configuration for CI run: "\n*** Please tell me who you are.\n\nRun\n\n git config --global user.email \"you@example.com\"\n git config --global user.name \"Your Name\"\n\nto set your account's default identity.\nOmit --global to set the identity only in this repository.\n\nfatal: unable to auto-detect email address (got 'root@4fe1699c8229.(none)')\n". Let me try to tweak something into working.

paulo-ferraz-oliveira commented 3 years ago

This is now, again, ready for review.