inaka / elvis_core

The core of an Erlang linter
Other
61 stars 56 forks source link

Fix `protocol_for_deps` allow for `git_subdir`'s `ref` and `tag` #373

Closed paulo-ferraz-oliveira closed 2 weeks ago

paulo-ferraz-oliveira commented 2 weeks ago

Description

We:

Closes #370.

paulo-ferraz-oliveira commented 2 weeks ago

I'm spelunking into the code: [0-9]+([.][0-9]+)*) was introduced in the regex in 0.2.9, but I'm still trying to find why (or what for).

Edit: oh, I think I see it... https://github.com/inaka/elvis_core/commit/12a966e537cd094560562da4056a17cdc150446c If we're still interested in supporting Erlang.mk we should keep it, but it needs to be updated; otherwise we can drop it.