search

inaka / erlang_guidelines

Inaka's Erlang Coding Guidelines
Apache License 2.0
623 stars 121 forks source link

abuse might be much better #88

Closed getong closed 5 years ago

elbrujohalcon commented 5 years ago

Thanks @getong, but even when I understand your intention with the change, that's not what the rule said. Don't abuse macros means "It's OK to use macros, but not if you're going to do non-trivial stuff with them." Don't use macros has the opposite spirit, intentionally. It means "You should never use macros, unless you're absolutely certain that there is no other way to achieve the same goal without them."

Also, "Don't abuse macros, except for very specific cases…" seems to imply that in those cases you are actually abusing macros, where actually you are not: Those are the places where it's OK to use a macro.

So, this time, we'll not accept the suggested change. Sorry.

getong commented 5 years ago

Thanks for your explaination, it is ok.