search

inaka / sumo_db

Erlang Persistency Framework
http://inaka.github.io/sumo_db/
Apache License 2.0
174 stars 37 forks source link

Upgrade sumo_db dependencies #331

Closed x80486 closed 6 years ago

x80486 commented 6 years ago

While using inaka/sumo_db_pgsql I noticed that worker_pool is using the already deprecated gen_fsm:

[gorre@uplink erl_hulk]$ rebar3 dialyzer
...
===> Fetching sumo_db_pgsql ({git,
                                     "git://github.com/inaka/sumo_db_pgsql.git",
                                     {ref,
                                      "849ef56ef4f4bcca09e55cfa24603d6e6c56e648"}})
===> Fetching epgsql ({pkg,<<"epgsql">>,<<"3.3.0">>})
===> Fetching sumo_db ({pkg,<<"sumo_db">>,<<"0.7.3">>})
...
===> Compiling worker_pool
===> Compiling _build/default/lib/worker_pool/src/wpool_fsm_process.erl failed
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:56: gen_fsm:start_link/4 is deprecated and will be removed in a future release; use gen_statem:start_link/4
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:61: gen_fsm:send_event/2 is deprecated and will be removed in a future release; use gen_statem:cast/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:65: gen_fsm:sync_send_event/2 is deprecated and will be removed in a future release; use gen_statem:call/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:69: gen_fsm:sync_send_event/3 is deprecated and will be removed in a future release; use gen_statem:call/3
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:73: gen_fsm:send_all_state_event/2 is deprecated and will be removed in a future release; use gen_statem:cast/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:77: gen_fsm:sync_send_all_state_event/2 is deprecated and will be removed in a future release; use gen_statem:call/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:83: gen_fsm:sync_send_all_state_event/3 is deprecated and will be removed in a future release; use gen_statem:call/3
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:88: gen_fsm:send_event/2 is deprecated and will be removed in a future release; use gen_statem:cast/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:92: gen_fsm:sync_send_all_state_event/2 is deprecated and will be removed in a future release; use gen_statem:call/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:294: gen_fsm:reply/2 is deprecated and will be removed in a future release; use gen_statem:reply/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:297: gen_fsm:reply/2 is deprecated and will be removed in a future release; use gen_statem:reply/2
_build/default/lib/worker_pool/src/wpool_fsm_process.erl:300: gen_fsm:reply/2 is deprecated and will be removed in a future release; use gen_statem:reply/2

I think it would be nice to review and upgrade the (internal) dependencies of sumo_db and sumo_db_pgsql.