search

inaka / worker_pool

Erlang worker pool
https://hex.pm/packages/worker_pool
Apache License 2.0
276 stars 80 forks source link

Improve function spec in wpool_sup #145

Closed michalwski closed 6 years ago

michalwski commented 6 years ago

This PR is to branch rel-3.1 as we need this change in esl/MongooseIM but are not able to use current master branch of worker_pool since we still want to support Erlang/OTP 19 and 20 in MongooseIM.

elbrujohalcon commented 6 years ago

Thank you, @michalwski :)

michalwski commented 6 years ago

@elbrujohalcon now, how can we make sure that the rel-3.1 branch is not removed accidentally? We'll need this branch in Mongoose for next 2 years (when officially supported versions will be 21,22,23).

michalwski commented 6 years ago

Oh, and thanks for merging the PR :)

elbrujohalcon commented 6 years ago

You don't really need the branch, @michalwski … you need releases based on that branch, right? But, in any case, I can protect it for you. I'll do that now.

elbrujohalcon commented 6 years ago

The branch is protected now.

michalwski commented 6 years ago

Thanks for protecting the branch. We are going to improve pools in esl/MongooseIM and there will probably be some changes to worker_pool. We'll use the rel-3.1 branch for these changes. Later these changes most probably will go to the master branch as well.

Regarding release, yes eventually we need them. They are not made after every PR merged, though.