search

inaka / worker_pool

Erlang worker pool
https://hex.pm/packages/worker_pool
Apache License 2.0
276 stars 80 forks source link

Move from timer:sleep to ktn_task:wait_for in tests #146

Closed elbrujohalcon closed 6 years ago

elbrujohalcon commented 6 years ago

As @michalwski correctly points out in #137 comments, timer:sleep is not a good thing to use, specially not in CI tests, that's why CT provides ct:sleep as a replacement. But we know better, we have ktn_task:wait_for so that's the one we should use.

michalwski commented 6 years ago

@elbrujohalcon could you create a PR with the same change to the rel-3.1 branch? If not I'll do it anyway.

elbrujohalcon commented 6 years ago

@michalwski stay tuned… PR is coming your way today or tomorrow :)