inaka / worker_pool

Erlang worker pool
https://hex.pm/packages/worker_pool
Apache License 2.0
276 stars 80 forks source link

[#154] adding integration with Travis+Codecov #157

Closed ferigis closed 6 years ago

ferigis commented 6 years ago

[close #154]

elbrujohalcon commented 6 years ago

@ferigis shouldn't we add some badge to the README.md, too?

ferigis commented 6 years ago

yes @elbrujohalcon, I am just testing if this works or not. If it works I will add the html in order to see the nice button in the readme just testing :)

michalwski commented 6 years ago

This will not work yet. A codecov.json file needs to be created based on *.coverdata file. There is a rebar3 plugin for it:

{rebar3_codecov, {git, "https://github.com/zofpolkowska/rebar3_codecov.git", {ref, "3d0af19"}}}
codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ef342e5). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #157   +/-   ##
=========================================
  Coverage          ?   96.19%           
=========================================
  Files             ?        9           
  Lines             ?      394           
  Branches          ?        0           
=========================================
  Hits              ?      379           
  Misses            ?       15           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef342e5...ed38ce8. Read the comment docs.

ferigis commented 6 years ago

thanks @michalwski I think it is working now

elbrujohalcon commented 6 years ago

Merged and added to #155 as well.