Closed wk8 closed 8 years ago
I don't seem to be able to access the logs from failed checks, but I imagine they try to compile with an older version of erlang?
@wk8 the server seems to be down (judging by enomem
). We'll check, soon.
@wk8 Your PR reminded me of a change we implemented before to deal with something related to this warnings (i.e. the wpool_pool:rnd/1
and associated functions). Our goal was to let users compile/use wpool in OTP < 18 (using random
) and OTP ≥ 18 (using rand
).
Your PR showed that change was only half-done, I fixed that in #72 and I finally removed the warnings (with a different approach) in #73.
As you can see: I'm not particularly friend of macros and platform definitions.
I'm closing this PR since the problem is solved. Feel free to reopen it if you disagree.
Works with me, thanks!
Fixing the following compilation warnings under OTP 19.0: