Update PHPUnit to latest (7.3.5). Fixes #44.

inakiabt / etsy-php

Etsy API wrapper for PHP

74 stars 59 forks source link

Update PHPUnit to latest (7.3.5). Fixes #44. #45

Closed michaelborn closed 6 years ago

michaelborn commented 6 years ago

This brings the phpunit tests up to spec with the latest PHPunit version.

syntaxCheck is no longer a valid config option in phpunit.xml
PHPUnit_Framework_TestCase is now namespaced under PHPUnit\Framework\TestCase

Hooray, no errors when testing anymore!

inakiabt commented 6 years ago

First of all, thank you so much for this! 🎉

I'm seeing that the build is still failing in Travis https://travis-ci.org/inakiabt/etsy-php/jobs/435947132

michaelborn commented 6 years ago

You're welcome! I saw that after I pushed and I wasn't sure what to do about it. Updating the phpunit dependencies ultimately requires PHP packages which require a newer version of PHP. I'm going to update travis.yml to require PHP 7.1, is that ok?

inakiabt commented 6 years ago

Yes! Sure.

michaelborn commented 6 years ago

Booyah! Ok, so upgrading PHPunit meant I also had to upgrade the oauth library AND the php version in travis.yml.