inamiy / YIFullScreenScroll

Pinterest-like scroll-to-fullscreen UI for iOS5+.
http://www.cocoacontrols.com/controls/yifullscreenscroll
214 stars 27 forks source link

Does not understand statusbar #26

Closed alper closed 10 years ago

alper commented 10 years ago

When the code does work (I hardcoded some values to fix my previous issue) it does not really take into account the statusbar. The navbar does scroll out of view but because it is not aware of my status bar it does not scroll back entirely.

It only scrolls back the height of the navbar minus the height of the statusbar.

inamiy commented 10 years ago

Same for here. Can you reproduce the bug in demo project?

alper commented 10 years ago

In the demo project this looks to be going fine, but for me it's like this: ios_simulator__iphone_retina_4inch_64bit__ios_7 0 3_11b508_20140310_102145 ios_simulator__iphone_retina_4inch_64bit__ios_7 0 3_11b508_20140310_102214

I don't understand which setting could affect this.

inamiy commented 10 years ago

In your case, I guess you are using YIFullScreenScrollStyleFacebook but trying to add UIButtons directly onto UINavigationBar instead of using UIBarButtonItems.

As you can see button's fadeout code here, they will only fade if they are normal UIBarButtonItems.

If I'm wrong, can you please attach your UIBarButtonItem's code?

alper commented 10 years ago

I don't have any code for it, they are just UIBarButtonItems:

cuppings xcworkspace__mainstoryboard storyboard_20140310_104448

inamiy commented 10 years ago

Hm, I see...

But current demo project (+ adding UIBarButtonItem in storyboard) still works fine, so there should be some other reason in your code that breaks default fading behavior.

Adding breakpoint around the fading code and test run will be helpful to you.

alper commented 10 years ago

It would seem that obj.customView are nil. Are these supposed to be set somewhere?

inamiy commented 10 years ago

I finally found the issue and you were right! I fixed it in 2f4dc14 , so please try :)

pkotesh-systango commented 9 years ago

Hey, I am facing this issue again. I am using a segmented control in the Navigation Bar. Can you please tell me how can I fix this?