search

inaos / iron-array

2 stars 0 forks source link

Avoid duplicated code in post filters views #577

Closed martaiborra closed 2 years ago

martaiborra commented 2 years ago

The prop*postfilter could be written as a single post filter by computing inside them view->typesize / source->typesize.

FrancescAlted commented 2 years ago

While doing this, remember to add .nthreads=1; while I am not sure this has any effect on multithreading (it should not, as AFAIK, _blosc_getitem is not multi-thread), it looks like it helps fixing some issues with that (discovered during my experiments with the helgrind tool of valgrind and test_slice_type.c).