inas0ng / pe

0 stars 0 forks source link

findp's implementation #3

Open inas0ng opened 1 year ago

inas0ng commented 1 year ago

I think the current implementation of findp could pose an issue to users.

Let's say I input "findp al", hoping to find Alice Pauline to edit her details afterwards. And then I backspace in hopes to clear the command input so that I can enter "editp [index]" to edit Alice's details. However, the moment I backspace to "findp a" (the L is removed), the find-query changes and more names appear, potentially changing Alice's index. The only workaround way I can think of is having to use my mouse and click-drag delete the enter command OR press enter, such that the search for "findp al" remains and I can perform "editp [index]" on Alice. This however may not be intuitive since the search is so reactive.

Screenshot 2023-04-14 at 2.34.24 PM.png

Screenshot 2023-04-14 at 2.34.32 PM.png

In this case, her index remains at 1 but other cases it may change the index due to differing searches. Hope this is clear :3

Edit: likewise, with findt's implementation

nus-pe-bot commented 1 year ago

Team's Response

This is an intentional design consideration that took considerable time to implement, as this is how a dynamic search bar works on other platforms as well such as Google and other search implementation bars. We had also mentioned this in our UG.

Screenshot 2023-04-16 at 11.12.05 AM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]