inasafe / inasafe-django

Django project for InaSAFE related services
Other
4 stars 15 forks source link

Issue #254: Upgrade Django 1.8 #314

Closed za closed 5 years ago

za commented 5 years ago

254

codecov[bot] commented 5 years ago

Codecov Report

Merging #314 into develop will decrease coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #314     +/-   ##
==========================================
- Coverage    52.37%   52.27%   -0.1%     
==========================================
  Files           92       92             
  Lines         4344     4344             
  Branches       388      388             
==========================================
- Hits          2275     2271      -4     
- Misses        1993     1997      +4     
  Partials        76       76
Impacted Files Coverage Δ
django_project/realtime/models/earthquake.py 79.22% <0%> (-1.3%) :arrow_down:
django_project/realtime/tasks/earthquake.py 34.61% <0%> (-1.1%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ba2a63...2a89a1a. Read the comment docs.

lucernae commented 5 years ago

Thanks for contributing as always @za :). Do you plan on working on this issue #254 ? We are currently short on hand. We already upgraded some part to Django 1.8, but not all. We really appreciate if you can fix some convention to proper Django 1.8 even some part of it :D

za commented 5 years ago

@lucernae Yes, I'll try to contribute :-)

za commented 5 years ago

BTW @lucernae what was the previous Django version before this upgrade? I found it's already pinning to 1.8. I am planning to fix this:

Django context needs to be separated because of new function convention:

lucernae commented 5 years ago

Yes @za We're already using Django 1.8 but some view function convention is still using the old one. BTW, I'm going to merge this because we're not using devserver anymore. Thanks!

lucernae commented 5 years ago

Yes @za We're already using Django 1.8 but some view function convention is still using the old one. BTW, I'm going to merge this because we're not using devserver anymore. Thanks!

za commented 5 years ago

@lucernae OK ;-)