Fix script pre_translate.sh

inasafe / inasafe-doc

Documentation project for InaSAFE

5 stars 27 forks source link

Fix script pre_translate.sh #334

Closed adisadit closed 8 years ago

adisadit commented 8 years ago

@timlinux hi Tim, could you check this PR? Like what you suggest in https://github.com/inasafe/inasafe-doc/pull/332 i comment those line and tried to run the script again. And i didn't see any error. So, i assume this script work without those line.

timlinux commented 8 years ago

Hi @adissadis

It would be better if in this PR you made a branch which included only the changes to the scripts and not all the other tr updates.

adisadit commented 8 years ago

@timlinux do you mean i separate the scripts fix and tr update and push those branch into this PR?

adisadit commented 8 years ago

@timlinux i already made a branch in my repo (pre_transifex_merge) but i don't know how to push this branch to this PR

timlinux commented 8 years ago

@adissadis if you do (from your branch):

git push origin <branch name>

Then go to your GitHub fork on the web and make a pull request from there.

adisadit commented 8 years ago

@timlinux okay i already do it in https://github.com/inasafe/inasafe-doc/pull/335

so can i merge this Pull request?