[Bug] IFCW: Cannot click next button after choose hazard data

[adisadit]

Problem

I cannot click Next button when i want to select hazard from disk. The next button is unavailable even i already select the earthquake hazard.

This problem also appear in IFCW using Tsunami and Flood.

Expected Behaviour

After i select EQ hazard from disk, i can click Next button to proceed to the next step.

Environment

• InaSAFE : 3.4 from repository QGIS
• QGIS : 3.14.3
• OS : Windows 7 64 bit
• Data used :
  • Exposure : Java population or Sumatera population
  • Hazard : EQ Jogjakarta or Padang EQ, Maumere Tsunami, Flood HKV
  • Aggregation :

    Proposed Solution

cc: @Charlotte-Morgan @ismailsunni @samnawi

[Charlotte-Morgan]

Hi @borysiasty - I've put your name on this one. It sounds like something we had once before? @timlinux @Gustry

[borysiasty]

It seems the browser lives its own life. LayerBrowserProxyModel is not set (the non-layer files like .xml and .qgs should be filtered out), and the selection signal is not connected (besides the unlocked button, there should be a layer keywords summary on the right). I'll be investigating it tomorrow.

[borysiasty]

@ismailsunni: please see PR #2924

[NyakudyaA]

@ismailsunni has this been merged into develop yet. I am running develop and I still cannot click next.

[borysiasty]

@NyakudyaA: Please read the description on the right. The layer's classes are not suitable for the selected impact function (the incompatible parameter is always written with italic font).

[Gustry]

Ok, so it might be related to https://github.com/inasafe/inasafe/issues/2941

I wonder why the colour is grey @borysiasty. And we should highlight what is wrong with the layer. In this case, it's classes.

[borysiasty]

@Gustry The colour is grey in order to be consistent with the inactive Next button. It is gray if you select a layer that you can't use, and black if you can use it. I thought it's quite intuitive, but I'm not any UX guy... :) The italic font shows what is wrong. We could make it italic + bold, but to would be probably too much. Please note we are limited to the Qt palette.

[Charlotte-Morgan]

Hi @Gustry and @borysiasty I can confirm that this is still a problem. QGIS 2.14.3 InaSAFE 3.5 dev (assuming this has been merged)

problem 1

I have a dataset with no key words assigned. I am using the IFCW and chose eq on pop; raster on raster; ITB When i find my EQ raster on disk I am unable to select next

expected behaviour

I can select next and will immediately be taken to kw wizard to assign kw

problem 2

I have a dataset with key words assigned. I am using the IFCW and chose eq on pop; raster on raster; ITB function When i find my EQ raster on disk I am unable to select next and it does not appear to have read the key words - ie there is no info on the right to show kw are being read

expected behaviour

I would expect to see the kw details in the right of the IFCW screen I would expect to be able to click next because there are not really many options for EQ hazard kw

[Charlotte-Morgan]

@NyakudyaA - here is an example of it working I select volcano polygon on raster population; polygon volcano on pop IF when I select my data on disk, it tells me what KW it sees and what it is looking for (great +1)

I can backtrack through the wizard and choose volcano point on raster pop and the point volcano on pop IF yay - my next button is active

[Charlotte-Morgan]

@Gustry - sometimes a user will select the wrong option for their available data and have to go back and change options to access the data they have.

What we do not accomodate is a dataset that has the wrong kw assigned :)

[NyakudyaA]

@Gustry I think it would be better to allow a user to redefine his keywords in situations where his keywords are wrong. Rather than close IFCW and redefine KW and then come back again to IFCW.
For the example above the classes that are in the layer are flood_vector_hazard_classes but the required classes are generic_vector_hazard_classes. So I suggest to ask the user whether he wants to redefine the keywords just to make it more interactive.

[Charlotte-Morgan]

We need to consider two scenarios. Firstly, the user has selected the wrong IF for their data and needs to go back and choose the right if. This resembles the original plan for a data centric wizard. Secondly, the data have the wrong key words. This happens to me because i dodgy the data to try things. But should we expect this for normal users. I think we should assume the first scenario in most cases.

[borysiasty]

@Charlotte-Morgan - just one note: your screenshots are from before my fix! Please ensure you reinstalled Inasafe (and reloaded QGIS) correctly.

If you can see various unwanted files in the browser like .qgs and .xml, and only vector layers work (what is your case), it means your installation clearly doesn't contain the fix.

[Charlotte-Morgan]

My apologies. I thought I had the latest version. As the ticket was closed I assumed the work was merged.

[borysiasty]

@Charlotte-Morgan: The work is merged to develop. So as long as you see e.g. *.xml files in the browser, it seems you don't use the current develop :) Something didn't refresh. I don't know how do you install it - just by git pull from develop?

[timlinux]

@NyakudyaA can you verify this is working now and get one of us to close it if it is working.

[NyakudyaA]

@timlinux I cannot replicate this. The issue seems to be centered on defining key words. If the layer has wrong keywords then you cannot click next.