inasafe / inasafe

InaSAFE - QGIS plugin for estimating impact from natural disasters
www.inasafe.org
GNU General Public License v3.0
258 stars 136 forks source link

Empty report map when using IFCW on volcano on buildings #2925

Closed NyakudyaA closed 8 years ago

NyakudyaA commented 8 years ago

Problem

After running IFCW for volcano on buildings using http://docs.inasafe.org/en/training/socialisation/run_other_hazards.html. The report is generated fine but the map is blank because the resultant layer are not toggled on by default. I have my QGIS settings as not to draw any layers added.

Custom qgis configuration.

setup

Layers added are not on by default. result

Generated report contains blank map.

empty

Expected Behaviour

Generate report with map visible.

Environment

Overwrite any custom qgis settings and add any layers as toggled on in QGIS when using any inasafe process.

NyakudyaA commented 8 years ago

@Gustry has this been implemented yet because it still does not set the loaded layers as active when I retested it today using the develop branch.

Gustry commented 8 years ago

Feel free to reopen if you notice the problem, I will check later

NyakudyaA commented 8 years ago

i have tested this: classified

Inasafe version : 3.15

NyakudyaA commented 8 years ago

i have tested this: classified

Inasafe version : 3.15

Gustry commented 8 years ago

Hum, ok I misunderstood your problem I think.

3 weeks ago, I made a fix to make the impact layer visible, even if the QGIS checkbox (By default, new layers added to the map should be displayed) is not checked. So now, every new layer provided by InaSAFE should be visible.

But your last two comments, it's not a layer provided by inasafe. You loaded these layers from QGIS. So your issue should be "the wizard and the dock doesn't show layers which are not visible". And this is a feature, not a bug ! inasafe 3 5 0 dev-dc76c8c options_003

Ok, I admit, the settings is speaking about the dock only, not the wizard. I'm going to fix the label.

NyakudyaA commented 8 years ago

@Gustry I did not load the layer using QGIS. I loaded the layers using IFCW. According to your fix they should automatically draw if they are loaded by inasafe. That is the behavior I was reporting that it was not working as expected.

Gustry commented 8 years ago

I made a fix for the impact layer added at the end of the IFCW. Not for layers added while running the frist questions in the IFCW. Do you think that InaSAFE should override the QGIS settings when we load a hazard/exposure layer using IFCW ? There are two settings in conflict : QGIS about new layer not visible by default, and InaSAFE not showing hidden layers

NyakudyaA commented 8 years ago

I understand but the impact layer added at the end of IFCW does not seem to be behaving that way. The layer added is not on by default. I think inasafe should override the default QGIS settings and show the layers as visible as i think it also affect other options like choosing AOI for analysis.

options

You cannot drag on map to choose an area because it wil not be visible by default.

Gustry commented 8 years ago

Ok, yes it's a problem to draw the bounding box if layers are not visible. Can you try the PR #3000 ?

NyakudyaA commented 8 years ago

LGMT

Gustry commented 8 years ago

Thanks for the review