inaturalist / iNaturalistAndroid

Android app for iNaturalist.org
https://market.android.com/details?id=org.inaturalist.android
MIT License
165 stars 57 forks source link

IllegalArgumentException in SignInTask (upgrade Facebook?) #1230

Open kueda opened 2 years ago

kueda commented 2 years ago

https://console.firebase.google.com/u/0/project/inaturalist-ios/crashlytics/app/android:org.inaturalist.android/issues/d0d3eec98d12a5ae2d64ef449ad2766c

Caused by java.lang.IllegalArgumentException: org.inaturalist.android: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
       at android.app.PendingIntent.checkFlags(PendingIntent.java:378)
       at android.app.PendingIntent.getBroadcastAsUser(PendingIntent.java:648)
       at android.app.PendingIntent.getBroadcast(PendingIntent.java:635)
       at com.facebook.AccessTokenManager.setTokenExpirationBroadcastAlarm(AccessTokenManager.java:164)
       at com.facebook.AccessTokenManager.setCurrentAccessToken(AccessTokenManager.java:130)
       at com.facebook.AccessTokenManager.setCurrentAccessToken(AccessTokenManager.java:110)
       at com.facebook.AccessToken.setCurrentAccessToken(AccessToken.java:245)
       at com.facebook.login.LoginManager.finishLogin(LoginManager.java:719)
       at com.facebook.login.LoginManager.onActivityResult(LoginManager.java:242)
       at com.facebook.login.LoginManager$1.onActivityResult(LoginManager.java:181)
       at com.facebook.internal.CallbackManagerImpl.onActivityResult(CallbackManagerImpl.java:81)
       at org.inaturalist.android.SignInTask.onActivityResult(SignInTask.java:271

This error seems to come from the Facebook SDK, but that probably means we need to update the SDK now that we're targeting a more recent version of Android.

FWIW, I can replicate this in build 554, Android 12, Pixel 3.