inaturalist / iNaturalistAndroid

Android app for iNaturalist.org
https://market.android.com/details?id=org.inaturalist.android
MIT License
155 stars 56 forks source link

Treatment for hidden media #1308

Closed pleary closed 7 months ago

pleary commented 9 months ago

The website recently released a feature where curators can hide photos and sounds by using ModeratorActions. On the website we replace the media with a message saying "Content Hidden" which users can click to open a popover showing who hid the content, when it was hidden, and the message left by the curator as to why it was hidden. Ideally mobile apps implement at least the "Content Hidden" message for hidden media.

I made a test observation https://www.inaturalist.org/observations/185148530 which has a hidden photo, a hidden sound, as well as a hidden identification, and a hidden comment (these latter two will have separate tickets). In the API response for this observation, the media have an attribute hidden: true. They also have an attribute moderator_actions which contains information on the hiding action including the hiding user, date it was hidden, and the reason message added by the curator when hiding the content. Similar to images hidden for copyright violations, image URLs for hidden images are replaced with a placeholder saying the media was hidden. This is a fixed replacement image with English text that is not internationalized.

Ideally hidden media would be treated as a special case, rendering a message similar to "Content Hidden", that can be localized for the viewing user. If it makes sense to do so and there is room, the hiding user, date of hiding, and hiding reason could also be displayed somewhere. The hiding reason could be long, and on the web we only show it in a popover.

In summary:

kueda commented 7 months ago

Since I'm still seeing the problem I reported in Slack in v1.30.1+594, here are some repro steps:

  1. As a test user, create an observation with a photo
  2. As an admin user, view that observation on the website and hide the photo by clicking the eye icon below the photo and creating a ModeratorAction. Confirm that the photo says "Content Hidden" on the web with an option to "Show Hidden Content"
  3. In the app, sign in as the test user who created the obs and photo, and tap on the obs to get to ObsDetail
  4. Instead of the localized UI described in this issue, you see the placeholder MEDIA HIDDEN photo

Screenshot_20231116-182640

When I view the test observation linked above (i.e. when I'm viewing someone else's observation), I see the localized "Content Hidden" UI. I expect to see the same thing when viewing my own observation.

budowski commented 7 months ago

@kueda - step 3 - is the observation viewed from your observation list? Or from explore? If not from explore, can you double check that it does work there?

Thanks