Closed kueda closed 3 years ago
Coming along, but still some changes to make:
source
is visual
, submit the lat
and lng
params but not the place_lat
and place_lng
params; when source
is rg_observations
, submit the place_lat
and place_lng
params but not the lat
and lng
params. lat
and lng
will override their place_*
equivalents.taxon_id
param has rank_level
is <= 10 (species or below), submit its parent's ID instead, e.g. if the filter taxon is a species, submit the ID of the genus that contains it (or whatever its parent is). Generally we want to show people suggestions of related taxa, not the children of the taxon that is already chosensource
is rg_observations
source
is rg_observations
, instead of the "We're not confident" message, say "Most observed options matching filters"pretty_sure_rank
translation key with separate keys for all possible ranks, falling back to pretty_sure_rank
if none of them exist. English values should have lowercase rank names, e.g. pretty_sure_genus: We're pretty sure it's in this genus
taxon_id
or place_id
(or place_lat
or place_lng
) if the user has intentionally removed the corresponding filterrg_observations
. Since you're not actually submitting the different photo the results won't change.rg_observations
the header "Most observed options matching filters" should be "Most-observed options matching filters:"Only one remaining issue I can find, and I don't think it needs to block merging this into the main branch:
Some requests from the Forum, from me, and some crashes:
This is an experiment right now, so please work on this in a branch so we can test before getting this into the production pipeline. Design and text are likely to change, so IMO, not worth spending too much time on UI refinement until we get those firmed up.Ok, Abhas actually put together some nice designs for a larger set of the changes we've discussed, so I'm updating this issue to reflect that. Note that with these broader changes, it might be helpful to switch to using the taxa/suggest endpoint instead of the computervision endpoints.
Only show Visually Similar & Seen Nearby results in the taxon chooser by default
vision_score
and afrequency_score
by default. Continue to sort them by theircombined_score
as we're currently doingvision_score
sorted by theirvision_score
. This will also toggle the button to say "Only view nearby suggestions" and tapping it will return to the prior statevision_score
and afrequency_score
, show the taxa with avision_score
sorted byvision_score
by default with no button at the bottom of the listThe preference to view include the
frequency_score
results or not doesn't need to be sticky right now, but might need to be in the future.Show multiple observation photos, allow viewer to choose the photo being used for suggestions
Allow choice of suggestion sources
source: visual
andsource: rg_observations
[TODO for @kueda: taxa/suggest may not incorporate the date in the way we probably want to, but we can add an option to do that, likemonths=7,8,9
or something]Filter suggestions by taxon and place
taxon_id
andplace_id
in API requests for suggestions