search

inaturalist / iNaturalistReactNative

Cross-platform version of the iNat mobile app
MIT License
54 stars 16 forks source link

Hide wikipedia link in TaxonDetails if there's no URL #1740

Open albullington opened 1 week ago

albullington commented 1 week ago

Describe the bug There are some edge cases like this one where a taxon can have a wikipedia description but not a url. So we're showing a wikipedia link that the user can't open.

To Reproduce Steps to reproduce the behavior:

  1. Go to Strangalia acuminata Taxon Details screen via Explore
  2. Tap on Read more on Wikipedia link
  3. Nothing happens

Expected behavior Right now, we're checking to see if a user can open the link and doing nothing if the wikipedia url doesn't exist. Instead, we should hide the "Read more on Wikipedia" link (or defer to @abhasinat on what the preferred UX is here).

Context (please complete the following information): OS: iOS App version: v0.34.0+97

abhasinat commented 1 week ago

Yep, hide the "Read more on Wikipedia" link if no wikipedia URL exists for the taxon.

kueda commented 6 days ago

Note, also merits some exploration of why the link for that specific taxon isn't working, b/c the wikipedia page exists.