inaturalist / iNaturalistReactNative

Cross-platform version of the iNat mobile app
MIT License
71 stars 24 forks source link

Tapping on obs w/o evidence from My Observations takes you to obs edit #313

Closed kueda closed 1 year ago

kueda commented 1 year ago

Describe the bug When you tap an observation without evidence on My Observations you end up on Obs Edit instead of Obs Detail.

To Reproduce Steps to reproduce the behavior:

  1. Make an observation without evidence
  2. Tap on it in My Observations
  3. You land on Obs Edit instead of Obs Detail

Expected behavior You should land on Obs Detail. An observation without evidence is just like any other observation

Context (please complete the following information):

albullington commented 1 year ago

Is this for an observation that has already been uploaded to the server or for an observation that is pending upload?

Issue #282 made it so any observation that has not been uploaded yet will land a user back on Obs Edit, instead of Obs Detail.

kueda commented 1 year ago

I guess it's any observation that hasn't been uploaded. What was the thinking there? I'm fine if that's a temporary fix for something, but if that's the case maybe it would help to show a toast or something to that effect.

albullington commented 1 year ago

This is something Abhas recorded in our last mobile sync bug hunt as a way the UX should work. In the mobile sync notes, it's under bug hunt, Abhas, and the first item under home screen: "When clicking on a saved observation, it should open obs edit, not obs detail (which is populated with nothing)"

kueda commented 1 year ago

Thanks. Looks like that was on 11/29.