inbasic / bulk-media-downloader

A cross-browser extension to detect and download media resources
https://webextension.org/listing/bulk-media-downloader.html
135 stars 53 forks source link

Some UI Colors issue. #11

Open j000 opened 7 years ago

j000 commented 7 years ago

Please either specify both background and text colours or neither of them for elements. Your default maybe black, but not everyone's else is. Thanks.

What do I see: Imgur What I expect to see: Imgur

inbasic commented 7 years ago

Are you using a custom theme or this is just FF dev theme? I am not having this issue with FF dev theme

j000 commented 7 years ago

Firefox uses system colours in many things. On Windows by default it's black on white and not many people change it, because it's not consistent - many applications have hardcoded black on white. On Linux we have the possibility to easily change system colours and use different themes. My system has light text with dark background. In this case Firefox uses system foreground (light grey) on background you specify (white) which results in unreadable text.

And I know there is not a lot of Linux users and many don't use theme with dark background, but IMHO it's not a big deal to you to set both, while it's a big issue to me, as you can see in screenshot.


BTW in web design it's WCAG (accessibility guidelines) issue: https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/F24.

inbasic commented 7 years ago

IMHO it's not a big deal to you to set both, while it's a big issue to me, as you can see in screenshot

The new version should have fixed the issue. I was asking this to be able to test before releasing.

j000 commented 7 years ago

Oh. Than thank you very much and sorry for such a long rant :)

Just set both colours - it's good enough. Or open dev tools and add something like

* {
color: white;
background-color: black;
}

Any more specific rule (in this case: every other rule) will override it and you'll see the result.

On screenshots you see that only buttons look broken. RegExp filter has no colors set.