inbasic / ignotifier

Multiple account Gmail notifier (without storing passwords)
https://webextension.org/listing/gmail-notifier.html
Other
396 stars 116 forks source link

Display all accounts at all times #16

Closed ghost closed 12 years ago

ghost commented 12 years ago

If all accounts, or the one with which I want to compose a new message with, is without any new notifications, I have no 'convenient' way of accessing it.

I'd suggest displaying all accounts upon hoovering the icon at all times. And, if with no new, let there be no count at all, not even a (0).

inbasic commented 12 years ago

Showing all read-accounts all the time might be frustrating for some users, instead you can now access all logged-in account by Ctrl + Left-click on the toolbar icon,

The enhancement is applied here: https://github.com/inbasic/ignotifier/tree/0.1.9beta/src \ This is not the origin branch **

ghost commented 12 years ago

0.1.9 works, thanks for the change.

Issue: I have 2 accounts. When I Ctrl + Left-click I see 3 accounts displayed (2 duplicate entries of 1 account and 1 of the the other). I believe it is the default account that is displayed twice. When clicked though, the correct account is accessed.

ghost commented 12 years ago

Oh, one more thing, can it be Alt + Left-click instead, it's easier to reach for with a single hand on a touch-pad?

inbasic commented 12 years ago

The reason why there are two duplicated items in the list is because most likely you have two feeds for the same account (one for inbox and the other one listening for a label). This is now fixed https://github.com/inbasic/ignotifier/commit/a8c7c394d75f8cf10b24d59e7518959626533372.

You can also open the prompt by either Alt+Left Click or Ctrl+Left click

\ Updated xpi is available in 0.1.9beta channel **

ghost commented 12 years ago

Hmm, it's 0.1.9b2 in Add-ons Manager page now but Alt + Left-click does nothing at all (Ctrl is fine). Am actually still working with modding the filters. But, nonetheless, the duplication is fixed.

inbasic commented 12 years ago

Alt works fine in Desktop, I have no clue why you don't have it in your touchpad.

To track this down, I have turned on the debuging mode in 0.1.9beta channel. Please install the latest one and open your "JS Console" (Ctrl+Shift+J), turn the Messages on and check the logs printed when you do Ctrl+Click or Alt+Click.

ghost commented 12 years ago

Ctrl click gives me this (sometimes with the error, sometimes not) but Alt click gives me nothing:

info: gmail-notifier: [onClick] ctrlKey: true


info: gmail-notifier: [onClick] altKey: false


info: gmail-notifier: [onClick] shiftKey: false


Error: TypeError: arr[i] is undefined Source file: resource://app/modules/XPIProvider.jsm -> jar:file:///E:/Mozilla%20Firefox/Profile/Lastborns/extensions/jid0-GjwrPchS3Ugt7xydvqVK4DQk8Ls@jetpack.xpi!/bootstrap.js -> resource://jid0-gjwrpchs3ugt7xydvqvk4dqk8ls-at-jetpack/api-utils/lib/loader.js -> resource://jid0-gjwrpchs3ugt7xydvqvk4dqk8ls-at-jetpack/gmail-notifier/lib/main.js Line: 71


info: gmail-notifier: [onCommand] ctrlKey: true


info: gmail-notifier: [onCommand] altKey: false


info: gmail-notifier: [onCommand] shiftKey: false

inbasic commented 12 years ago

So is this bug fixed?

Here is the behavior expected from the extension:

  1. Left click only: Open Gmail. If you have feeds for labels other than inbox, then it should direct you to the right page now (in the latest update for channel 0.1.9beta). https://github.com/inbasic/ignotifier/issues/7
  2. Left click + Alt/Ctrl: List of all logged-in accounts. Always direct user to the inbox of accounts.
ghost commented 12 years ago

With regard to the subject line, yes. Thanks.