inbasic / ignotifier

Multiple account Gmail notifier (without storing passwords)
https://webextension.org/listing/gmail-notifier.html
Other
393 stars 116 forks source link

Update messages.json v3 for (en) #672

Closed Need74 closed 2 months ago

Need74 commented 2 months ago

Hi

I noticed that two lines are not translatable on Transifex and that they are missing in the English source file on Transifex.
These lines are the lines:

"popup_toggle_dark": { "message": "Toggle dark theme on and off" },

"options_tab_11": { "message": "Open the newest unread email instead of opening the INBOX folder" },

The lines are already on Github v3 but missed in Transifex.

I also saw that the term "and" is without a space before and after and that the text is less pretty. To avoid this I suggest putting a non-breaking space before and after (Alt255)

I also updated the Italian translation on Transifex while noting that it was more than 2 years old and that it is no longer present on Github.

Italian is also in fact not available on the plug-in and if we change the language of Chrome or Firefox the plug-in is then displayed in English.

Regards

inbasic commented 2 months ago

I noticed that two lines are not translatable on Transifex and that they are missing in the English source file on Transifex.

Right, Transifex's update link was messed up so I had to reset. Please upload your existing translations to Transifex.

I also saw that the term "and" is without a space before and after and that the text is less pretty.

We already have it

https://github.com/inbasic/ignotifier/blob/master/v3.classic/data/options/index.html#L113

Need74 commented 2 months ago

I noticed that two lines are not translatable on Transifex and that they are missing in the English source file on Transifex.

Right, Transifex's update link was messed up so I had to reset. Please upload your existing translations to Transifex.

I also saw that the term "and" is without a space before and after and that the text is less pretty.

We already have it

https://github.com/inbasic/ignotifier/blob/master/v3.classic/data/options/index.html#L113

Hi Thanks for this feedback and indeed it is much more judicious to work on the HTML index file for the layout.

I have just found a few more errors that disrupt the translation of the English text by Transifex. and I have made a new PR

You can close this PR as it is no longer relevant. Regards