inbasic / media-player

A simple yet powerful media player for browser built on top of video.js
https://webextension.org/listing/the-media-player.html
36 stars 27 forks source link

[Update Request] Firefox addon is out of date #37

Open chromer030 opened 2 years ago

chromer030 commented 2 years ago

Thank you for this great and useful extension , Firefox version is stuck on version 0.2.0 and Last updated is a year ago (May 22, 2021) , please update it to latest version like chrome.

Thank you very much.

https://addons.mozilla.org/en-US/firefox/addon/the-media-player/

inbasic commented 2 years ago

The 0.4.3 release was rejected by AMO due to the use of the "cast" plugin. I'll submit a new version without this plugin, and hopefully, it gets passed.

chromer030 commented 2 years ago

Thank you very much for your efforts , New version without some features is far better than old version without some features.

chromer030 commented 2 years ago

@inbasic , any update ?

inbasic commented 2 years ago

I tried several times to push the latest release. Each time I get a rejection letter like the following. Although there are references where the libs are taken from (see README files next to the libs), the reviewer wants the official link. The problem is that these libraries do not provide official links. They recommended using the CDN version, but the reviewer does not accept them. Have no idea how to proceed.

Details:
Established libraries must be included from their official source, in their original format without any modification (changing the file name does not matter). Please note that only stable releases are acceptable (not beta, pre, RC, dev etc) and that third party CDNs are not considered official sources.
- data\player\video.js\plugins\wavesurfer\wavesurfer.js
- data/player/video.js/plugins/playlist/videojs-playlist.js
- data/player/video.js/plugins/playlist-ui/videojs-playlist-ui.js

Version(s) affected and disabled:
0.4.4.1
********
chromer030 commented 2 years ago

So please provide .xpi file Github release for every version , so users can download and install them manually. It's not best solution but can be a alternative one , until a way could be found for AMO.

With .xpi files released in Github every feature will be available like cast ! , and you are not obliged to remove some feature in order to satisfy the reviewer and etc.

Thanks a lot for all your efforts for this great addon/extenstion.

chromer030 commented 2 years ago

It's possible to drag and drop and install firefox .xpi addons without any issues :

For example this one , in firefox 104 :

Screenshot_20220822_150042

inbasic commented 2 years ago

It is not possible! XPI needs to be signed. Without the signing, you cannot drag and drop to install.

chromer030 commented 2 years ago

You are right , i didn't notice that , even prominent Ublock Origin XPI files released in Github are signed. So the only way is AMO.