inbasic / turbo-download-manager

a multi-browser download manager with multi-threading support
http://add0n.com/turbo-download-manager.html
312 stars 87 forks source link

Incorrect detection of existing file #45

Closed pkonstantinov closed 8 years ago

pkonstantinov commented 8 years ago

The downloader detected that the file with initial name already exists, then adds a digit to the end of the file name and stops in pause state. But file with name+NUMBER doesn't exist and download should be started automatically.

inbasic commented 8 years ago

Is this on Opera?

pkonstantinov commented 8 years ago

FireFox 46.0.1 64 bit

inbasic commented 8 years ago

Is this happening for all names? How can I re-generate the bug?

pkonstantinov commented 8 years ago

Just try to download the same file second time. No?

On Sat, May 21, 2016 at 5:55 PM, InBasic notifications@github.com wrote:

Is this happening for all names? How can I re-generate the bug?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/inbasic/turbo-download-manager/issues/45#issuecomment-220771504

Pavel Konstantinov, QA Engineer GridGain Systems www.gridgain.com

pkonstantinov commented 8 years ago

Windows 10 (10586.318), Firefox 64 bit 46.0.1

On Mon, May 23, 2016 at 3:52 PM, Pavel Konstantinov < pkonstantinov@gridgain.com> wrote:

Just try to download the same file second time. No?

On Sat, May 21, 2016 at 5:55 PM, InBasic notifications@github.com wrote:

Is this happening for all names? How can I re-generate the bug?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/inbasic/turbo-download-manager/issues/45#issuecomment-220771504

Pavel Konstantinov, QA Engineer GridGain Systems www.gridgain.com

Pavel Konstantinov, QA Engineer GridGain Systems www.gridgain.com

inbasic commented 8 years ago

Just try to download the same file second time. No?

So if a very same file is being downloaded the second time, there should be the warning as the file is already been downloaded (or been created and is still in the download list)

inbasic commented 8 years ago

closing due to inactivity.

pkonstantinov commented 8 years ago

The problem I described in initial issue still exist. Just try to download this file two times: http://gridgain.com/media/gridgain-enterprise-fabric-7.6.3.zip. On second attempt downloader will rename the file to 'gridgain-enterprise-fabric-7.6-2.3.zip' but I think it should be 'gridgain-enterprise-fabric-7.6.3-2.zip'

pkonstantinov commented 8 years ago

More over, IMHO after renaming downloader should detect that the file with new name doesn't exist and automatically start download.

inbasic commented 8 years ago

From version "0.3.2", you can open the config editor window and search for "wget.pause-on-exists" . Change the value to false for auto start after renaming.

inbasic commented 8 years ago

The naming issue also will be fixed on this new release. Thanks for the report.