search

inblockio / aqua-verifier-webextension

A Chrome-Browser web-extension to verify Aqua Protocol data.
https://inblock.io
MIT License
6 stars 2 forks source link

feat: 🎸 rendering witness result data object instead of formatted HTML #70

Closed lobogang closed 6 months ago

lobogang commented 2 years ago

Screen Shot 2022-04-11 at 23 02 21 Screen Shot 2022-04-11 at 23 02 13

rht commented 2 years ago

Still missing https://github.com/inblockio/aqua-verifier-js/blob/de3432e7309c642159e756ddf7dc49e602ab660d/index.js#L544-L564= ?

FantasticoFox commented 2 years ago

Looks like we need some form of visual grouping to make clear this is all witness data. Right now I could not tell.

lobogang commented 2 years ago

Still missing https://github.com/inblockio/aqua-verifier-js/blob/de3432e7309c642159e756ddf7dc49e602ab660d/index.js#L544-L564= ?

good point. I'll add that in an upcoming commit

lobogang commented 2 years ago

Looks like we need some form of visual grouping to make clear this is all witness data. Right now I could not tell.

Do you have some ideas for how to do this? I think this is a place where some design would be useful. I only used the former HTML output and this documentation: https://github.com/inblockio/aqua-verifier-webextension/issues/47#issuecomment-1016208813. Perhaps finetuning the layout can be done in another PR once we're sure we have all the data rendering to the page correctly

rht commented 6 months ago

I rebased this PR.