inbo / LSVI

Rekenmodule Lokale Staat Van Instandhouding van habitattypen
https://inbo.github.io/LSVI/
GNU General Public License v3.0
1 stars 0 forks source link

Dubbels in invoer #148

Closed ElsLommelen closed 5 years ago

ElsLommelen commented 5 years ago

Uitwerking van issue #126: controle dat er geen dubbels zijn in de invoer.

In tegenstelling tot eerdere afspraken leek het me beter om in dit geval een error te geven i.p.v. een warning (zie uitleg bij issue). Extra's die mee uitgewerkt zijn:

Offtopic extra:

codecov-io commented 5 years ago

Codecov Report

Merging #148 into develop will increase coverage by 0.43%. The diff coverage is 84.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
+ Coverage    68.65%   69.09%   +0.43%     
===========================================
  Files           44       44              
  Lines         3516     3621     +105     
===========================================
+ Hits          2414     2502      +88     
- Misses        1102     1119      +17
Impacted Files Coverage Δ
R/invoercontroleData_habitat.R 94.11% <100%> (+1.8%) :arrow_up:
R/invoercontroleData_voorwaarden.R 92.59% <100%> (+3.11%) :arrow_up:
R/invoercontroleData_soortenKenmerken.R 88.77% <67.92%> (-4.59%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf4bd2a...49a0869. Read the comment docs.

ToonHub commented 5 years ago

Akkoord om error te geven ipv van warning!