search

inbo / aspbo

The alien species portal backoffice contains automated data preparation scripts for the [alien species portal](https://github.com/inbo/alien-species-portal)
0 stars 0 forks source link

Rework timeseries creation to contain species with observation after 1950 #199

Open SanderDevisscher opened 6 days ago

SanderDevisscher commented 6 days ago

Currently species introduced prior to 1950 are excluded from the GAM timeseries this should be reworked to match option 2 of https://github.com/inbo/alien-species-portal/pull/74#issuecomment-2191167596. ea species should be included in the timeseries if they have at least 1 observation after 1950 independent of their year of introduction. This means the logic discribed here should be reworked.

https://github.com/inbo/aspbo/blob/ea385cec983aeddadf47cd7785112ad4c4c53730/src/05_occurrence_indicators_preprocessing.Rmd#L374

soriadelva commented 4 days ago

I've altered the code but @SanderDevisscher could you run the upload of the timeseries to the S3-bucket because I don't get permission to do that (still the same error as before)? Also I changed the name of one of the output files in the data/output folder from taxa_introduced_in_BE_before_1950.tsv to taxa_last_observed_in_BE_before_1950.tsv, but I'm not sure whether this may be throwing errors downstream. According to #135 this file has to be placed in the interim folder so it may be fine.

mvarewyck commented 4 days ago

We don't use that file taxa_introduced_in_BE_before_1950.tsv, so for me renaming is fine.

SanderDevisscher commented 3 days ago

We don't use that file taxa_introduced_in_BE_before_1950.tsv, so for me renaming is fine.

=> #135 remains TRUE

SanderDevisscher commented 3 days ago

I've altered the code but @SanderDevisscher could you run the upload of the timeseries to the S3-bucket because I don't get permission to do that (still the same error as before)? Also I changed the name of one of the output files in the data/output folder from taxa_introduced_in_BE_before_1950.tsv to taxa_last_observed_in_BE_before_1950.tsv, but I'm not sure whether this may be throwing errors downstream. According to #135 this file has to be placed in the interim folder so it may be fine.

@soriadelva you can allways trigger the workflow from a branch, see https://github.com/inbo/aspbo/actions/workflows/update_indicators_preprocessing.yaml. As long as you run it from uat afterwards.

soriadelva commented 3 days ago

I've altered the code but @SanderDevisscher could you run the upload of the timeseries to the S3-bucket because I don't get permission to do that (still the same error as before)? Also I changed the name of one of the output files in the data/output folder from taxa_introduced_in_BE_before_1950.tsv to taxa_last_observed_in_BE_before_1950.tsv, but I'm not sure whether this may be throwing errors downstream. According to #135 this file has to be placed in the interim folder so it may be fine.

@soriadelva you can allways trigger the workflow from a branch, see https://github.com/inbo/aspbo/actions/workflows/update_indicators_preprocessing.yaml. As long as you run it from uat afterwards.

@SanderDevisscher ik krijg die workflow precies niet te zien als ik onder actions kijk 🤔