Open PietrH opened 5 days ago
I would't read custom resources:
read_camtrapd()
if they were all loaded all the time. I think we should stick with the camtrapdp official resources.frictionless::read_resource()
Alrighty! I would suggest making note of this behaviour (we don't read everything, only default tables) in the documentation of read_camtrapdp()
Ok, please do. 👍
@damianooldoni We discussed the read_camtrapdp()
behaviour here
I still consider reading these out of scope. The user of camtrapdp doesn't know data are attached to x$data
, so having data attached there isn't necessarily useful. I would inform of the additional resources in print() (working on updating the PR) and indicate that those can be loaded with frictionless::read_resource().
frictionless::read_resource()
currently only supports tabular resources
Indeed, thus not something we control (and should implement in) camtrapdp. Informing additional resources exist is sufficient.
While working on the print method I came across the fact that there are less
x$data
objects thanx$resources
forexample_dataset()
:example_dataset()
currently includes one non standard resource:individuals
, currently this resource is not read in byread_camtrapdp()
at all.This is certainly possible because it's a simple json array, very quick and dirty:
Created on 2024-07-03 with reprex v2.1.0
We'd also have to account for custom tabular data I suppose?
Is this something we want to support? It certainly feels convenient, but might be a hassle to maintain because it seems quite open ended. Opinions?