inbo / camtraptor

Camtraptor is an R package to read, explore and visualize Camera Trap Data Packages (Camtrap DP)
https://inbo.github.io/camtraptor/
MIT License
10 stars 2 forks source link

Search results on pkgdown website link to wrong page #197

Closed peterdesmet closed 1 year ago

peterdesmet commented 1 year ago
  1. Go to https://inbo.github.io/camtraptor/index.html
  2. Type "Read" in the search bar at the top
  3. Click on the first suggested result in the dropdown: Reference > Read a Camtrap DP — read_camtrap_dp
  4. Result link to: https://inbo.github.io/reference/read_camtrap_dp.html?q=Read#null

Rather than the expected: https://inbo.github.io/camtraptor/reference/read_camtrap_dp.html?q=Read#null

This also affects:

frictionless, bioRad, wateRinfo and rgbif are not affected.

@PietrH can you debug this one?

PietrH commented 1 year ago

I'm having a look

PietrH commented 1 year ago

I'm having trouble replicating this, it's possibly due to url: ~ in _pkgdown.yml, however I haven't been able to test this hypothesis. I've found examples of similar _pkgdown.yml on github that do seem to work, but that's possibly because they pages were built before a breaking change somewhere in the stack. Or it might be something else entirely.

Later on this week I'll have another go at this issue.

peterdesmet commented 1 year ago

Oh, that's a good guess. I'm curious if anyone has reported it at pkgdown.

PietrH commented 1 year ago

@damianooldoni and I had a brief discussion about this issue today.

To clarify: I can confirm the issue, but haven't been able to create a new website with pkgdown that has the same problem.

So far I've been debugging off a fork of existing packages with the issue, but later on this week I'll try starting from a blank slate (a new, repo, a new package). Thanks for the suggestion.

PietrH commented 1 year ago

Discussed with @damianooldoni, to move to milestone v1.0

peterdesmet commented 1 year ago

This is now fixed. It is indeed necessary to change url: ~ to an absolute domain name. I have also updated (or recorded to update) the other packages this affects.