search

inbo / camtraptor

Camtraptor is an R package to read, explore and visualize Camera Trap Data Packages (Camtrap DP)
https://inbo.github.io/camtraptor/
MIT License
10 stars 2 forks source link

Use calendar values in `get_custom_effort` #278

Closed damianooldoni closed 1 year ago

damianooldoni commented 1 year ago

This PR solves #219 by using calendar weeks/months/years for grouping while calculating the effort.

Unit-tests in test-get_custom_effort() have been not only updated, but also sensibly improved partly based on testthat things learned while working on #272 thanks to @PietrH.

damianooldoni commented 1 year ago

Notice that we consider this work as a hotfix, so version is bumped to 0.20.1.

damianooldoni commented 1 year ago

Thank you for the review! I will now check all comments are capitalized. Next time, remove directly the whitespaces in a commit, if you wish. I think it will save time for both. But many thanks to find them.

PietrH commented 1 year ago

Thanks for the changes. Good job! I'll commit small stylistic changes directly next time.

Ok to merge!