Closed damianooldoni closed 4 months ago
Contrarely to what I thought few days ago, I am more and more convinced that camtraptor should not support reading functionalities anymore. In other words, no wrappers around camtrapdp's read_camtrap_dp()
function.
I see a similarity with tidyverse ecosystem where dplyr is not reading a file, but starts from a data.frame. camtrapdp is the "readr", camtraptor the "dplyr".
I spoke about this with @PietrH during a coffee break and he agrees.
@peterdesmet, @sangovae, any opinion is welcome.
After a coffie corner ☕ discussion, we decided to still maintain the reading functionality within camtraptor. Of course, it will use camtrapdp under the hood.
In this way:
%>%
. It is imported in dplyr from magrittr and exported as it is so that users can use it while loading dplyr. The same is done in camtrapdp
, which imports the pipe to export it as it is.camtrapdp::read_camtrapdp()
if we ever need to do so.We also agreed to name the function as in camtrapdp, i.e. read_camtrapdp()
. The existing function with an extra underscore, read_camtrap_dp()
will get deprecated in version 1.0. To be removed a year later or so.
The argument path
, which is deprecated since years, will be not supported anymore and will be removed.
IMPORTANT: OUTDATED: we will not remove this function. See https://github.com/inbo/camtraptor/issues/298#issuecomment-2112636999 here below.
The reading functionality has been moved to camtrapdp package. Same function name.
This function must therefore be removed within camtraptor.
package
as first argument.