inbo / camtraptor

Camtraptor is an R package to read, explore and visualize Camera Trap Data Packages (Camtrap DP)
https://inbo.github.io/camtraptor/
MIT License
10 stars 2 forks source link

Remove predicate functions - use `filter_deployments()` #316

Open damianooldoni opened 2 months ago

damianooldoni commented 2 months ago

Once #315 is completed, we can replace the predicates with filter functions. Here below the most important steps:

PietrH commented 2 months ago

Functions should not do any filtering at all internally, any filtering should happen before and be piped in.

So lines using predicates can just be removed.

PietrH commented 2 months ago

We should make a new vignette about the filtering functions : how to read data, how to manipulate camtrapdp objects

PietrH commented 2 months ago

There are still references to mica in my branch:

https://github.com/inbo/camtraptor/blob/a10adc1adc5ef8d2fc8b40b58894a8225f03de37/R/get_n_species.R#L14

Probably should remove these, I don't want to do this in the same branch

PietrH commented 2 months ago

I should also scan the package of the word filter in the documentation and examples, as well as keep an eye out for triple dots: ...

damianooldoni commented 1 month ago

Based on good practices, we must make these functions defunct, instead of just removing them.