Closed hansvancalster closed 7 months ago
I just noticed that there is a problem with this fix in case the project is not a git version controlled project. At least, I think that is the reason why the unit test test_e_bookdown_zenodo.R
fails.
I just noticed that there is a problem with this fix in case the project is not a git version controlled project. At least, I think that is the reason why the unit test
test_e_bookdown_zenodo.R
fails.
Fixed in bb0fc57. The one failing test seems unrelated to changes in this PR?
The failing unit test is due to a problem with zen4R
.
Anything else that needs to be done for this PR? I think it's ready to be merged in bugfix branch.
This should fix a bug where
.zenodo.json
file was incorrectly flagged as modified. The relative path to the file should be relative to the root of the git repository. This failed in cases wheremeta$get_path
is a child directory beneath the git root repository. Thegert
package usesgert::git_find
to find the git parent directory in case a child directory is passed to therepo =
argument. So the proposed change should make sure that thefile
argument inis_tracked_not_modified
is relative to the path passed to itsrepo
argument (which gets passed down to repo argument ofgert
functions and thus resolve togert::git_find(repo)
.