inbo / checklist

An R package for checking R packages and R code
https://inbo.github.io/checklist
GNU General Public License v3.0
16 stars 2 forks source link

Version 0.3.6 #120

Closed ThierryO closed 2 months ago

wlangera commented 4 months ago

Hi @ThierryO

I will do a more thorough revision in the beginning of June. Here already some comments regarding renv:

1. I get an error message when I create a new project

The following message shows in the console:

Error: unexpected end of input
Execution halted

You can continue creating the checklist project. After the last question, this warning shows in the console:

Warning message:
In system(cmd, intern = intern, wait = wait | intern, show.output.on.console = wait,  :
  running command 'C:\Windows\system32\cmd.exe /c Rscript -e 'renv::init("C:/Users/ward_langeraert/Documents/test", restart = FALSE)'' had status 1

I have the latest version of renv (1.0.7).

2. This version of checklist successfully ignores renv related files which was not the case with checklist version 3.5. So this is great :)

ThierryO commented 3 months ago

@hansvancalster can you please test create_project(). 09e8044 and 0ebd61b should solve the issues you raised.

hansvancalster commented 2 months ago

@hansvancalster can you please test create_project(). 09e8044 and 0ebd61b should solve the issues you raised.

I just tried. This is more clear now, but I would suggest a different solution that avoids popup screens on Windows. I just read the documentation of utils::askYesNo which is used by checklist::ask_yes_no and it appears the popup is triggered by the default of the prompts argument. Using another default avoids the popup:

image

So I suggest changing the default of prompts argument in checklist::ask_yes_no(msg, default = TRUE, prompts = getOption("askYesNo", gettext(c("Yes", "No", "Cancel"))), ...) to checklist::ask_yes_no(msg, default = TRUE, prompts = c("Yes", "No", "Cancel"), ...). In that case the cli_alert_info message about possible popup hidden behind other screens can be removed altogether.