search

inbo / checklist

An R package for checking R packages and R code
https://inbo.github.io/checklist
GNU General Public License v3.0
16 stars 2 forks source link

create_package: suggestions for CONTRIBUTING file #15

Closed ElsLommelen closed 3 years ago

ElsLommelen commented 4 years ago

When reading the file CONTRIBUTING.md generated when using function create_package(), I noticed the last line refers to the 'git2rdata project'. Would it be possible to add the package name of the newly created package here (instead of 'git2rdata')? Another option would be to just omit 'git2rdata' and refer to 'this package'.

Also, in the section Fixing typos in this file, personally I think the wording with YES and NO reads rather difficult. It would be much shorter and straightforward to write it in one sentence such as E.g. edit a roxygen comment in a `.R` file below `R/`, not in an `.Rd` file below `man/`.

ThierryO commented 4 years ago

Goog suggestions. Would you send a PR into the 0.1.5 branch?

ThierryO commented 3 years ago

Solved in #27