check RStudio project - Githubissues

inbo / checklist

An R package for checking R packages and R code

https://inbo.github.io/checklist

GNU General Public License v3.0

19 stars 2 forks source link

check RStudio project #5

Open ThierryO opened 4 years ago

ThierryO commented 4 years ago

[ ] check for existing RStudio project file
[ ] use 2 spaces for tab
[ ] UTF-8 encoding
[ ] 1 Rproj at the repo root
[ ] 1 Rproj at the package root (in case package root != repo root)
[ ] no Rproj files in subfolders of the package
- inst and its subfolders can hold max 1 Rproj per (sub)folder
[ ] git config --local is set so that \r\n is replaced with \n
[ ] check package building settings

ElsLommelen commented 4 years ago

To which extend could enforcing these Linux standards (UTF-8 and \n) possibly cause problems when packages are used in Windows 7? Up to now I haven't come across such problems, but in this case it would be nice to have the possibility of a motivated exception. (Only needed as long as Windows 7 is used at INBO, so you might choose to leave it as is and change it temporary if these rules cause problems.)

ThierryO commented 4 years ago

The \n is a git thing and should not affect Windows users. On Windows, git will store Windows style line ending as Unix style line endings in the git history.

I've not seen any issue with the UTF-8 setting so far. I'd enforce this until further notice. We can reconsider if it causes unfixable problems.