Closed ElsLommelen closed 3 years ago
Probably due to differences in OS handling of case-sensitivity in folder and filenaming? Windows is case-insensitive, while ubuntu is case-sensitive.
Ah, yes indeed, all errors are due to the use of uppercase (or -
vs _
).
Is there maybe any possibility to check it locally as well? The default in Windows is indeed case-insensitivity, but in a lot of R functions it is possible to choose for case-sensitivity. It would be helpful to not have to push commits and wait for the checks to find out this type of problems. Also, in case of for instance a warning on the use of -
instead of _
: how to ignore these using write_checklist()
if these warnings do not show up locally?
Do you get uppercase names when you run the code below in your git repo?
library(git2r)
repo <- repository()
ls_tree(repo = repo, recursive = TRUE)
Can you check list.files(".", recursive = TRUE, all.files = TRUE)
too?
Yes, I get uppercase names in both cases.
A few more things to check:
basename("a/A.txt")
returns "A.txt"
grepl("[a-z]", c("a", "A"))
returns TRUE
, FALSE
If those things work as I expected them to work, then please run debug(check_filename)
and check_filename()
. And try to see where things go wrong.
Ok, it seems to work fine now: I get the same errors locally and on github.
When running
check_package()
orcheck_filename()
locally, I don't get any errors related to filenames, while the Github action check package (inbo/actions/check_pkg@master
) gives several errors concerning filenames (due to use of uppercase,...). Locally the following note is added to the output ofcheck_filename()
(I'm not sure it has something to do with the problem, but I don't see anything else that could be relevant to solve the problem):