Closed hansvancalster closed 1 year ago
Anything else that needs to be changed?
Yes. Please add a few unit tests that cover the code you've added.
I'm finalising #90. That might conflict with some of your changes.
This PR should be ready. The failing check on Windows is due to a more recent source version on CRAN of a package (this time openssl) compared to it's binary. This annoyance is explained in https://github.com/r-lib/actions/issues/141.
Maybe we should consider to use remotes::install_deps(dependencies = TRUE, type = "binary")
in GHA in case of Windows and Mac runners?
Can you replace the line in the GHA with this version? remotes::install_deps(dependencies = TRUE, type = ifelse(.Platform$OS.type=="unix", "source", "binary"))
Update the version in inst/package_template
too.
I'm having doubts about that last change. What if no binary is available for a package? I think https://github.com/r-lib/actions/tree/v2-branch/setup-r-dependencies solves these issues.
This PR adds the possibility to use a MIT license for packages. The default remains GPL-3.
One difficulty with the MIT license is that
<YEAR>
and<COPYRIGHT HOLDERS>
needs to be filled in. I leave the responsibility to do this to the user (as well as updating YEAR every time a new year starts 🥱) and the license check does not check this line (actually the first 4 lines of the MIT license file will be skipped). (an alternative could be to have a LICENSE.Rmd file withr format(Sys.Date(), "%Y")
which is knitted to LICENSE.md file)Related #83.