search

inbo / checklist

An R package for checking R packages and R code
https://inbo.github.io/checklist
GNU General Public License v3.0
16 stars 2 forks source link

V0.2.7 #93

Closed hansvancalster closed 1 year ago

hansvancalster commented 1 year ago

In case of a MIT license, a LICENSE file is needed in addition to a LICENSE.md. See https://r-pkgs.org/license.html and https://cran.rstudio.com/doc/manuals/r-devel/R-exts.html#Licensing.

This PR makes some changes to address this issue. The test for check_license() covers the case create_package(..., license = "MIT").

ThierryO commented 1 year ago

Did you check if #83 is fixed?

hansvancalster commented 1 year ago

Did you check if #83 is fixed?

Should be fixed in 093a354. Zenodo harvests licenses from https://spdx.org/licenses/. So I mapped it to the "MIT" abbreviation, which refers to https://opensource.org/licenses/MIT. The proof of the pudding whether this will work, is to actually publish something via a .zenodo.json file with a MIT license (but GPL-3 is also mapped to the corresponding abbreviation and that has worked before, so I expect no problems).

ThierryO commented 1 year ago

The proof of the pudding whether this will work, is to actually publish something via a .zenodo.json file with a MIT license (but GPL-3 is also mapped to the corresponding abbreviation and that has worked before, so I expect no problems).

Please do test this with a dummy repo and https://sandbox.zenodo.org.